Allow scoped application services to be accessed from the context #9009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bricelam
approved these changes
Jun 29, 2017
Issue #8797 After going back and forth on this I settled on: * Register DbContextOptions as scoped by default * This allows scoped services to be used in AddDbContext * This allows scoped services to be resolved from context.GetService * It will still work fine if scoped services are not needed * Add another parameter to AddDbContext to allow the options to be registered as Singleton if needed * This can be used for apps that are doing some heavy lifting in AddDbContext
ajcvickers
force-pushed
the
FreshAndMintyListerine0628
branch
from
c0a307c
to
c5e16a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #8797
After going back and forth on this I settled on: